refactor(connector): Move connectors Bamboraapac, Boku, Gocardless, Prophetpay, Rapyd #6652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spritianeja03
changed the title
spritianeja03
added
C-refactor
deepanshu-iiitu
requested changes
Dec 2, 2024
| @@ -28,6 +28,7 @@ rand = "0.8.5" | |||
| regex = "1.10.4" | |||
| reqwest = { version = "0.11.27" } | |||
| ring = "0.17.8" | |||
| roxmltree = "0.20.0" | |||
There was a problem hiding this comment.
Can we do this version
roxmltree = "0.19.0"
| ) => Self::Voided, | ||
| (RapydPaymentStatus::Error, _) => Self::Failure, | ||
| (RapydPaymentStatus::New, _) => Self::Authorizing, | ||
| // impl ForeignFrom<(RapydPaymentStatus, NextAction)> for enums::AttemptStatus { |
There was a problem hiding this comment.
Remove these comments
| } | ||
| } | ||
| // } |
There was a problem hiding this comment.
Remove these comments
deepanshu-iiitu
approved these changes
Dec 2, 2024
Narayanbhat166
approved these changes
Dec 2, 2024
SanchithHegde
approved these changes
Dec 2, 2024
| @@ -91,7 +91,6 @@ rdkafka = "0.36.2" | |||
| regex = "1.10.4" | |||
| reqwest = { version = "0.11.27", features = ["json", "rustls-tls", "gzip", "multipart"] } | |||
| ring = "0.17.8" | |||
| roxmltree = "0.19.0" | |||
There was a problem hiding this comment.
Thanks for removing the unused dependency!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Moved connectors Bamboraapac, Boku, Ebanx, Gocardless, Prophetpay and Rapyd from router crate to hyperswitch_connectors crate
Additional Changes
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy